| Summary: | Allow WebXR tests to be run on Mac | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||
| Component: | New Bugs | Assignee: | Ada Chan <adachan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ada Chan
2021-06-15 16:51:23 PDT
Created attachment 431501 [details]
Patch
Comment on attachment 431501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431501&action=review > LayoutTests/TestExpectations:4905 > +# WebXR - expected to fail. What about these are expected to fail? > LayoutTests/TestExpectations:4917 > +# rdar://79306047 > +http/wpt/webxr/xrSession_ended_by_system.https.html [ Skip ] This should probably have a bugzilla in addition to the radar. > LayoutTests/TestExpectations:4920 > +# rdar://79367325 > +imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https.html [ Skip ] This should probably have a bugzilla in addition to the radar. (In reply to Sam Weinig from comment #2) > Comment on attachment 431501 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431501&action=review > > > LayoutTests/TestExpectations:4905 > > +# WebXR - expected to fail. > > What about these are expected to fail? These sections of "skip" follow Dean's earlier attempt to enable these tests (https://trac.webkit.org/changeset/277468/webkit). I haven't gone through each of these tests to narrow down the reason of failure. Maybe a better title to use here is just "currently failing". > > > LayoutTests/TestExpectations:4917 > > +# rdar://79306047 > > +http/wpt/webxr/xrSession_ended_by_system.https.html [ Skip ] > > This should probably have a bugzilla in addition to the radar. > > > LayoutTests/TestExpectations:4920 > > +# rdar://79367325 > > +imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https.html [ Skip ] > > This should probably have a bugzilla in addition to the radar. I'll file bugzillas for these also and reference them here. Created attachment 431584 [details]
Patch for landing
Committed r278954 (238883@main): <https://commits.webkit.org/238883@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431584 [details]. |