Bug 22703

Summary:

Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
The patch	oliver: review+

Description Gavin Barraclough 2008-12-05 19:09:45 PST

je, jg etc take an immediate operand as the second argument, but for the equality branches (je, jne) the immediate operand is the first argument.  This is unnecessarily inconsistent.

Comment 1 Gavin Barraclough 2008-12-05 19:12:19 PST

Created attachment 25805 [details]
The patch

Comment 2 Gavin Barraclough 2008-12-05 19:25:26 PST

Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/wrec/WRECGenerator.cpp
Transmitting file data ....
Committed revision 39061.