Bug 22703

Summary: Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
The patch oliver: review+

Gavin Barraclough
Reported 2008-12-05 19:09:45 PST
je, jg etc take an immediate operand as the second argument, but for the equality branches (je, jne) the immediate operand is the first argument. This is unnecessarily inconsistent.
Attachments
The patch (9.29 KB, patch)
2008-12-05 19:12 PST, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2008-12-05 19:12:19 PST
Created attachment 25805 [details] The patch
Gavin Barraclough
Comment 2 2008-12-05 19:25:26 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/jit/JIT.cpp Sending JavaScriptCore/wrec/WRECGenerator.cpp Transmitting file data .... Committed revision 39061.
Note You need to log in before you can comment on or make changes to this bug.