Summary: | ANGLE Metal AutoObjCPtr == nullptr comparison is inverted | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||
Component: | ANGLE | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kimmo Kinnunen
2021-06-15 07:19:26 PDT
Created attachment 431436 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 431436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431436&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:276 > + bool operator==(const std::nullptr_t &) const { return this->get() == nullptr; } I think this can/should just be bool operator==(std::nullptr_t) const; > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:284 > + bool operator!=(const std::nullptr_t &) const { return this->get() != nullptr; } bool operator!=(std::nullptr_t) const; Created attachment 431438 [details]
Patch for landing
Committed r278926 (238857@main): <https://commits.webkit.org/238857@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431438 [details]. |