Bug 227026 – ANGLE Metal AutoObjCPtr == nullptr comparison is inverted

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Kimmo Kinnunen]

ANGLE Metal AutoObjCPtr  == comparison is inverted

[Kimmo Kinnunen]

Created attachment 431436 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Anders Carlsson]

Comment on attachment 431436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431436&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:276
> +    bool operator==(const std::nullptr_t &) const { return this->get() == nullptr; }

I think this can/should just be 

bool operator==(std::nullptr_t) const;

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:284
> +    bool operator!=(const std::nullptr_t &) const { return this->get() != nullptr; }

bool operator!=(std::nullptr_t) const;

[Kimmo Kinnunen]

Created attachment 431438 [details]
Patch for landing

[EWS]

Committed r278926 (238857@main): <https://commits.webkit.org/238857@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431438 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79385866>