Bug 227026 - ANGLE Metal AutoObjCPtr == nullptr comparison is inverted
Summary: ANGLE Metal AutoObjCPtr == nullptr comparison is inverted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-15 07:19 PDT by Kimmo Kinnunen
Modified: 2021-06-16 01:41 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2021-06-15 07:25 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch for landing (2.43 KB, patch)
2021-06-15 07:47 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-06-15 07:19:26 PDT
ANGLE Metal AutoObjCPtr  == comparison is inverted
Comment 1 Kimmo Kinnunen 2021-06-15 07:25:33 PDT
Created attachment 431436 [details]
Patch
Comment 2 EWS Watchlist 2021-06-15 07:26:34 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Anders Carlsson 2021-06-15 07:39:22 PDT
Comment on attachment 431436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431436&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:276
> +    bool operator==(const std::nullptr_t &) const { return this->get() == nullptr; }

I think this can/should just be 

bool operator==(std::nullptr_t) const;

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:284
> +    bool operator!=(const std::nullptr_t &) const { return this->get() != nullptr; }

bool operator!=(std::nullptr_t) const;
Comment 4 Kimmo Kinnunen 2021-06-15 07:47:08 PDT
Created attachment 431438 [details]
Patch for landing
Comment 5 EWS 2021-06-16 01:40:52 PDT
Committed r278926 (238857@main): <https://commits.webkit.org/238857@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431438 [details].
Comment 6 Radar WebKit Bug Importer 2021-06-16 01:41:25 PDT
<rdar://problem/79385866>