Bug 227024

Summary: ANGLE Metal gl sync objects do not work in case of listener being needed
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 222731, 226841, 227059    
Attachments:
Description Flags
Patch
none
Patch none

Description Kimmo Kinnunen 2021-06-15 06:37:31 PDT
ANGLE Metal gl sync objects do not work in case of listener being needed

The MTLSharedEventListener is nil due to sandbox.
Comment 1 Kimmo Kinnunen 2021-06-16 01:29:00 PDT
Created attachment 431525 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-06-16 01:29:54 PDT
Created attachment 431526 [details]
Patch
Comment 3 EWS Watchlist 2021-06-16 01:30:11 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Radar WebKit Bug Importer 2021-06-16 02:13:01 PDT
<rdar://problem/79387276>
Comment 5 Per Arne Vollan 2021-06-16 02:20:51 PDT
Comment on attachment 431526 [details]
Patch

R=me.
Comment 6 EWS 2021-06-16 04:52:11 PDT
Committed r278929 (238860@main): <https://commits.webkit.org/238860@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431526 [details].
Comment 7 Kenneth Russell 2021-06-16 10:53:31 PDT
Nice fix Kimmo! Deep magic.