Summary: | [GLib] Rewrite NetworkCache::Data::adoptMap without FileSystem::MappedFileData::leakHandle and munmap | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebKit2 | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cgarcia, cmarcelo, ews-watchlist, kkinnunen, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 227011 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2021-06-15 00:44:02 PDT
Created attachment 431411 [details]
WIP patch
Comment on attachment 431411 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=431411&action=review > Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm:98 > + const void* map = mappedFile.data(); Which do you need to change Cocoa code? The new code is less efficient. Comment on attachment 431411 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=431411&action=review >> Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm:98 >> + const void* map = mappedFile.data(); > > Which do you need to change Cocoa code? The new code is less efficient. This change isn't technically a mandatory for Bug 227017. I can keep FileSystem::MappedFileData::leakHande just for this. Because Bug 227017 is going to add HANDLE of a file mapping to MappedFileData, the combination of FileSystem::MappedFileData::leakHande and FileSystem::unmapViewOfFile is too problematic. That's the reason I want to remove. But, I can keep MappedFileData::leakHande by adding #if !OS(WINDOWS) if you like. (In reply to Fujii Hironori from comment #3) > Comment on attachment 431411 [details] > WIP patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431411&action=review > > >> Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm:98 > >> + const void* map = mappedFile.data(); > > > > Which do you need to change Cocoa code? The new code is less efficient. > > This change isn't technically a mandatory for Bug 227017. > I can keep FileSystem::MappedFileData::leakHande just for this. > > Because Bug 227017 is going to add HANDLE of a file mapping to > MappedFileData, the combination of > FileSystem::MappedFileData::leakHande and > FileSystem::unmapViewOfFile is too problematic. > That's the reason I want to remove. > > But, I can keep MappedFileData::leakHande by adding #if !OS(WINDOWS) if you > like. I think that would be good, since the replacement Cocoa code wouldn't be as efficient otherwise. OK. Thank you. Reopened. I'm going to fix only NetworkCacheDataGLib.cpp. Created attachment 431935 [details]
Patch
Comment on attachment 431935 [details] Patch Clearing flags on attachment: 431935 Committed r279137 (239049@main): <https://commits.webkit.org/239049@main> All reviewed patches have been landed. Closing bug. |