Bug 226997

Summary: Font::applyTransforms() can redirect GlyphBuffer's internal pointers
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dino, rniwa, sam, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2021-06-14 16:24:56 PDT
Font::applyTransforms() can redirect GlyphBuffer's internal pointers
Attachments
Patch (1.69 KB, patch)
2021-06-14 16:26 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.67 KB, patch)
2021-06-14 17:41 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-06-14 16:26:48 PDT
Created attachment 431381 [details] Patch
Myles C. Maxfield
Comment 2 2021-06-14 16:26:51 PDT
<rdar://problem/78704666>
Sam Weinig
Comment 3 2021-06-14 17:25:17 PDT
Comment on attachment 431381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431381&action=review > Source/WebCore/ChangeLog:11 > + Untested. I applaud the candor, but why is that?
Myles C. Maxfield
Comment 4 2021-06-14 17:41:43 PDT
Created attachment 431390 [details] Patch
Ryosuke Niwa
Comment 5 2021-06-14 17:58:58 PDT
(In reply to Sam Weinig from comment #3) > Comment on attachment 431381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431381&action=review > > > Source/WebCore/ChangeLog:11 > > + Untested. > > I applaud the candor, but why is that? Please see the radar.
Sam Weinig
Comment 6 2021-06-14 19:55:14 PDT
(In reply to Ryosuke Niwa from comment #5) > (In reply to Sam Weinig from comment #3) > > Comment on attachment 431381 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=431381&action=review > > > > > Source/WebCore/ChangeLog:11 > > > + Untested. > > > > I applaud the candor, but why is that? > > Please see the radar. Let's be a bit less cavalier with our word choices in the future then.
EWS
Comment 7 2021-06-14 20:34:47 PDT
Committed r278858 (238802@main): <https://commits.webkit.org/238802@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431390 [details].
Note You need to log in before you can comment on or make changes to this bug.