Summary: | [JSC] Workaround ICU uloc_addLikelySubtags / uloc_minimizeSubtags bugs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35201 https://bugs.chromium.org/p/chromium/issues/detail?id=1166143 |
||||||
Attachments: |
|
Description
Yusuke Suzuki
2021-06-14 16:24:46 PDT
Created attachment 431384 [details]
Patch
Comment on attachment 431384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431384&action=review All of our ICU workaround code honestly makes me want to cry, but r=me. 😅 > Source/JavaScriptCore/ChangeLog:18 > + This is workaround, and still this workaround is not complete since we could have many variants. In that case, uloc_addLikelySubtags / uloc_minimizeSubtags > + still fails, and in that case, for now, we give up performing uloc_addLikelySubtags / uloc_minimizeSubtags. Fixing this needs to be > + done in ICU side. We should create a JIRA ticket for this. > JSTests/stress/intl-long-locale-id-maximize-minimize.js:6 > + const __v_16 = new Intl.Locale(`de-Latn-DE-u-cu-eur-em-default-hc-h23-ks-level1-lb-strict-lw-normal-ms-metric-nu-latn-rg-atzzzz-sd-atat1-ss-none-tz-atvie-va-posix`); Let's use less cryptic variable names. Comment on attachment 431384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431384&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:18 >> + done in ICU side. > > We should create a JIRA ticket for this. Filed https://unicode-org.atlassian.net/browse/ICU-21639 >> JSTests/stress/intl-long-locale-id-maximize-minimize.js:6 >> + const __v_16 = new Intl.Locale(`de-Latn-DE-u-cu-eur-em-default-hc-h23-ks-level1-lb-strict-lw-normal-ms-metric-nu-latn-rg-atzzzz-sd-atat1-ss-none-tz-atvie-va-posix`); > > Let's use less cryptic variable names. Changed. Committed r278859 (238803@main): <https://commits.webkit.org/238803@main> |