Bug 226990

Summary: Remove Storage Access API quirk on live.com
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, esprehn+autocc, ews-watchlist, kangil.han, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Kate Cheney
Reported 2021-06-14 14:28:44 PDT
Remove Storage Access API quirk on live.com
Attachments
Patch (5.02 KB, patch)
2021-06-14 14:29 PDT, Kate Cheney 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2021-06-14 15:03 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2021-06-14 14:29:56 PDT
Created attachment 431365 [details] Patch
Brent Fulgham
Comment 2 2021-06-14 14:41:50 PDT
Comment on attachment 431365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431365&action=review r=me > Source/WebCore/page/Quirks.cpp:1055 > && (element.classNames().contains("glyph_signIn_circle") Observation: It sure seems like there should be a predicate that lets us test if one set contains any of another set...
Kate Cheney
Comment 3 2021-06-14 15:03:53 PDT
Created attachment 431369 [details] Patch
Kate Cheney
Comment 4 2021-06-14 15:05:14 PDT
(In reply to Brent Fulgham from comment #2) > Comment on attachment 431365 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431365&action=review > > r=me > > > Source/WebCore/page/Quirks.cpp:1055 > > && (element.classNames().contains("glyph_signIn_circle") > > Observation: It sure seems like there should be a predicate that lets us > test if one set contains any of another set... Agreed, this would be useful for quirks when we check for similar classnames. Awaiting EWS before landing. Thanks for the review!
EWS
Comment 5 2021-06-14 16:40:16 PDT
Committed r278852 (238798@main): <https://commits.webkit.org/238798@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431369 [details].
Kate Cheney
Comment 6 2021-06-14 16:41:09 PDT
rdar://79218986
Note You need to log in before you can comment on or make changes to this bug.