Bug 226990

Summary: Remove Storage Access API quirk on live.com
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, esprehn+autocc, ews-watchlist, kangil.han, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Description Kate Cheney 2021-06-14 14:28:44 PDT
Remove Storage Access API quirk on live.com
Comment 1 Kate Cheney 2021-06-14 14:29:56 PDT
Created attachment 431365 [details]
Patch
Comment 2 Brent Fulgham 2021-06-14 14:41:50 PDT
Comment on attachment 431365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431365&action=review

r=me

> Source/WebCore/page/Quirks.cpp:1055
>          && (element.classNames().contains("glyph_signIn_circle")

Observation: It sure seems like there should be a predicate that lets us test if one set contains any of another set...
Comment 3 Kate Cheney 2021-06-14 15:03:53 PDT
Created attachment 431369 [details]
Patch
Comment 4 Kate Cheney 2021-06-14 15:05:14 PDT
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 431365 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431365&action=review
> 
> r=me
> 
> > Source/WebCore/page/Quirks.cpp:1055
> >          && (element.classNames().contains("glyph_signIn_circle")
> 
> Observation: It sure seems like there should be a predicate that lets us
> test if one set contains any of another set...

Agreed, this would be useful for quirks when we check for similar classnames. 

Awaiting EWS before landing. Thanks for the review!
Comment 5 EWS 2021-06-14 16:40:16 PDT
Committed r278852 (238798@main): <https://commits.webkit.org/238798@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431369 [details].
Comment 6 Kate Cheney 2021-06-14 16:41:09 PDT
rdar://79218986