Bug 226988

Summary: [watchOS] Reenable modern text input UI for non-numeric text input types
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: FormsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, akeerthi, bdakin, cdumez, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
none
Remove unnecesary comment
none
Small adjustment
none
Rebase after r278910
none
Rebase on trunk
none
Fix more conflicts none

Description Wenson Hsieh 2021-06-14 14:06:31 PDT 
rdar://78102953
Comment 1 Wenson Hsieh 2021-06-14 15:43:28 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-06-14 15:59:10 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-06-14 16:06:22 PDT Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2021-06-14 16:14:24 PDT Comment hidden (obsolete)
Comment 5 Wenson Hsieh 2021-06-15 12:01:20 PDT 
Created attachment 431461 [details]
Remove unnecesary comment
Comment 6 Aditya Keerthi 2021-06-15 13:10:30 PDT 
Comment on attachment 431461 [details]
Remove unnecesary comment

View in context: https://bugs.webkit.org/attachment.cgi?id=431461&action=review

> Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:141
> +    [_contextView setFrame:CGRectMake((viewWidth - sizeThatFits.width) / 2, 0, sizeThatFits.width, sizeThatFits.height)];
> +    [_contextView layoutSubviews];

I don't think `layoutSubviews` is necessary – the frame change (specifically the change to size) should trigger layout.
Comment 7 Wenson Hsieh 2021-06-15 13:32:40 PDT 
(In reply to Aditya Keerthi from comment #6)
> Comment on attachment 431461 [details]
> Remove unnecesary comment
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431461&action=review
> 
> > Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:141
> > +    [_contextView setFrame:CGRectMake((viewWidth - sizeThatFits.width) / 2, 0, sizeThatFits.width, sizeThatFits.height)];
> > +    [_contextView layoutSubviews];
> 
> I don't think `layoutSubviews` is necessary – the frame change (specifically
> the change to size) should trigger layout.

Good catch! Removed this call to -layoutSubviews.
Comment 8 Wenson Hsieh 2021-06-15 13:34:53 PDT Comment hidden (obsolete)
Comment 9 Wenson Hsieh 2021-06-15 16:27:02 PDT Comment hidden (obsolete)
Comment 10 EWS 2021-06-16 13:27:22 PDT Comment hidden (obsolete)
Comment 11 Wenson Hsieh 2021-06-16 13:56:29 PDT Comment hidden (obsolete)
Comment 12 Wenson Hsieh 2021-06-16 14:17:46 PDT 
Created attachment 431602 [details]
Fix more conflicts
Comment 13 EWS 2021-06-16 15:18:45 PDT 
Committed r278957 (238885@main): <https://commits.webkit.org/238885@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431602 [details].