Bug 22698

Summary: In Chromium, pan scrolling should only be enabled on windows.
Product: WebKit Reporter: Tony Chang <tony>
Component: PlatformAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
[1/1] Only have pan scrolling on chromium win
eric: review-
[1/1] Only have pan scrolling on for WIN_OS eric: review+

Tony Chang
Reported 2008-12-05 15:59:20 PST
this is how it works on other platforms (wx, qt, etc)
Attachments
[1/1] Only have pan scrolling on chromium win (1.06 KB, patch)
2008-12-05 16:05 PST, Tony Chang 		eric: review-
DetailsFormatted DiffDiff
[1/1] Only have pan scrolling on for WIN_OS (963 bytes, patch)
2008-12-05 17:38 PST, Tony Chang 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2008-12-05 16:05:13 PST
Created attachment 25798 [details] [1/1] Only have pan scrolling on chromium win JavaScriptCore/ChangeLog | 8 ++++++++ JavaScriptCore/wtf/Platform.h | 2 +- 2 files changed, 9 insertions(+), 1 deletions(-)
Eric Seidel (no email)
Comment 2 2008-12-05 17:35:15 PST
Comment on attachment 25798 [details] [1/1] Only have pan scrolling on chromium win I think we should just turn in on by default for WIN_OS. Yeah, that turns it on for qt, but I expect they want it anyway.
Tony Chang
Comment 3 2008-12-05 17:38:58 PST
Created attachment 25803 [details] [1/1] Only have pan scrolling on for WIN_OS JavaScriptCore/ChangeLog | 8 ++++++++ JavaScriptCore/wtf/Platform.h | 2 +- 2 files changed, 9 insertions(+), 1 deletions(-)
Eric Seidel (no email)
Comment 4 2008-12-05 17:43:38 PST
Comment on attachment 25803 [details] [1/1] Only have pan scrolling on for WIN_OS LGTM.
Eric Seidel (no email)
Comment 5 2008-12-08 15:43:56 PST
M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Platform.h Committed r39106
Note You need to log in before you can comment on or make changes to this bug.