Bug 22698 - In Chromium, pan scrolling should only be enabled on windows.
Summary: In Chromium, pan scrolling should only be enabled on windows.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-05 15:59 PST by Tony Chang
Modified: 2008-12-08 15:43 PST (History)
0 users

See Also:


Attachments
[1/1] Only have pan scrolling on chromium win (1.06 KB, patch)
2008-12-05 16:05 PST, Tony Chang
eric: review-
Details | Formatted Diff | Diff
[1/1] Only have pan scrolling on for WIN_OS (963 bytes, patch)
2008-12-05 17:38 PST, Tony Chang
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2008-12-05 15:59:20 PST
this is how it works on other platforms (wx, qt, etc)
Comment 1 Tony Chang 2008-12-05 16:05:13 PST
Created attachment 25798 [details]
[1/1] Only have pan scrolling on chromium win

 JavaScriptCore/ChangeLog      |    8 ++++++++
 JavaScriptCore/wtf/Platform.h |    2 +-
 2 files changed, 9 insertions(+), 1 deletions(-)
Comment 2 Eric Seidel (no email) 2008-12-05 17:35:15 PST
Comment on attachment 25798 [details]
[1/1] Only have pan scrolling on chromium win

I think we should just turn in on by default for WIN_OS.  Yeah, that turns it on for qt, but I expect they want it anyway.
Comment 3 Tony Chang 2008-12-05 17:38:58 PST
Created attachment 25803 [details]
[1/1] Only have pan scrolling on for WIN_OS

 JavaScriptCore/ChangeLog      |    8 ++++++++
 JavaScriptCore/wtf/Platform.h |    2 +-
 2 files changed, 9 insertions(+), 1 deletions(-)
Comment 4 Eric Seidel (no email) 2008-12-05 17:43:38 PST
Comment on attachment 25803 [details]
[1/1] Only have pan scrolling on for WIN_OS

LGTM.
Comment 5 Eric Seidel (no email) 2008-12-08 15:43:56 PST
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/Platform.h
Committed r39106