Bug 226962

Summary: FilterEffectRendererCoreImage could be simpler and more memory efficient
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: CanvasAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: dino, ews-watchlist, kondapallykalyan, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226917    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Kimmo Kinnunen
Reported 2021-06-14 02:15:40 PDT
FilterEffectRendererCoreImage could be simpler and more memory efficient - functions applyEffects and renderToImageBuffer are simple functions that cannot function realistically without each other but work and mutate the object state - holds the bitmaps while allocating new bitmaps
Attachments
Patch (17.33 KB, patch)
2021-06-14 03:14 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (17.34 KB, patch)
2021-06-17 23:55 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-06-14 03:14:23 PDT
Created attachment 431308 [details] Patch
Kimmo Kinnunen
Comment 2 2021-06-17 23:55:44 PDT
Created attachment 431759 [details] Patch
Radar WebKit Bug Importer
Comment 3 2021-06-21 02:16:40 PDT
<rdar://problem/79553333>
Simon Fraser (smfr)
Comment 4 2021-06-21 10:31:15 PDT
This code is off by default.
Dean Jackson
Comment 5 2022-02-19 08:22:42 PST
Comment on attachment 431759 [details] Patch r=me although I would not be surprised if this patch no longer applies.
Said Abou-Hallawa
Comment 6 2022-05-31 12:22:57 PDT
FilterEffectRendererCoreImage was removed in r286193.
Note You need to log in before you can comment on or make changes to this bug.