| Summary: | Number pad button is missing its image when tapping on <input type=tel> in watchOS 8 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | Forms | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, benjamin, cdumez, cmarcelo, darin, ews-watchlist, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2021-06-12 11:50:24 PDT
Created attachment 431261 [details]
For EWS
Created attachment 431262 [details]
Fix watchOS 7 build
Created attachment 431263 [details]
Fix watchOS 7 build (2)
Comment on attachment 431263 [details] Fix watchOS 7 build (2) View in context: https://bugs.webkit.org/attachment.cgi?id=431263&action=review > Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:-67 > - UIImage *numberPadButtonIcon = [PUICResources imageNamed:@"QuickboardAddPhoneNumber" inBundle:[NSBundle bundleWithIdentifier:@"com.apple.PepperUICore"] shouldCache:YES]; So this is not needed on older builds with !HAVE(PUIC_BUTTON_TYPE_PILL)? Comment on attachment 431263 [details] Fix watchOS 7 build (2) View in context: https://bugs.webkit.org/attachment.cgi?id=431263&action=review Thanks for the review! >> Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:-67 >> - UIImage *numberPadButtonIcon = [PUICResources imageNamed:@"QuickboardAddPhoneNumber" inBundle:[NSBundle bundleWithIdentifier:@"com.apple.PepperUICore"] shouldCache:YES]; > > So this is not needed on older builds with !HAVE(PUIC_BUTTON_TYPE_PILL)? Yes — setting the Quickboard action type obviates the need for specifying this icon image on both watchOS 7+. Committed r278815 (238768@main): <https://commits.webkit.org/238768@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431263 [details]. |