| Summary: | [JSC] Add ValueOf fast path in toPrimitive | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 227416, 227418, 227419 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2021-06-11 18:27:46 PDT
Created attachment 431248 [details]
Patch
Created attachment 431789 [details]
Patch
Comment on attachment 431789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431789&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + value-of-call 65.7169+-0.6192 ^ 45.0986+-0.0830 ^ definitely 1.4572x faster The name of benchmark should probably indicate that it's not just valueOf but rather "valueOf via toPrimitive". (In reply to Ross Kirsling from comment #4) > Comment on attachment 431789 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431789&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:13 > > + value-of-call 65.7169+-0.6192 ^ 45.0986+-0.0830 ^ definitely 1.4572x faster > > The name of benchmark should probably indicate that it's not just valueOf > but rather "valueOf via toPrimitive". Thanks, changed. Committed r279053 (238973@main): <https://commits.webkit.org/238973@main> Will use this patch for webkitbot test. Please ignore following messages. Re-opened since this is blocked by bug 227416 Re-opened since this is blocked by bug 227419 |