Bug 226948

Summary: [JSC] Add ValueOf fast path in toPrimitive
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 227416, 227418, 227419    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch ross.kirsling: review+

Yusuke Suzuki
Reported 2021-06-11 18:27:46 PDT
[JSC] Add ValueOf fast path in toPrimitive
Attachments
Patch (2.44 KB, patch)
2021-06-11 18:28 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.67 KB, patch)
2021-06-18 23:57 PDT, Yusuke Suzuki 		ross.kirsling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-06-11 18:28:16 PDT
Created attachment 431248 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-06-18 18:28:26 PDT
<rdar://problem/79515947>
Yusuke Suzuki
Comment 3 2021-06-18 23:57:57 PDT
Created attachment 431789 [details] Patch
Ross Kirsling
Comment 4 2021-06-19 14:15:02 PDT
Comment on attachment 431789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431789&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + value-of-call 65.7169+-0.6192 ^ 45.0986+-0.0830 ^ definitely 1.4572x faster The name of benchmark should probably indicate that it's not just valueOf but rather "valueOf via toPrimitive".
Yusuke Suzuki
Comment 5 2021-06-20 02:45:08 PDT
(In reply to Ross Kirsling from comment #4) > Comment on attachment 431789 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431789&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:13 > > + value-of-call 65.7169+-0.6192 ^ 45.0986+-0.0830 ^ definitely 1.4572x faster > > The name of benchmark should probably indicate that it's not just valueOf > but rather "valueOf via toPrimitive". Thanks, changed.
Yusuke Suzuki
Comment 6 2021-06-20 02:48:13 PDT
Committed r279053 (238973@main): <https://commits.webkit.org/238973@main>
Yusuke Suzuki
Comment 7 2021-06-25 17:50:38 PDT
Will use this patch for webkitbot test. Please ignore following messages.
WebKit Commit Bot
Comment 8 2021-06-25 17:55:43 PDT
Re-opened since this is blocked by bug 227416
WebKit Commit Bot
Comment 9 2021-06-25 21:14:17 PDT
Re-opened since this is blocked by bug 227419
Note You need to log in before you can comment on or make changes to this bug.