Bug 22693

Summary: Remove m_assembler from MacroAssembler::Jump.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
The patch ggaren: review+

Gavin Barraclough
Reported 2008-12-05 13:57:31 PST
Keeping a pointer allowed for some syntactic sugar - "link()" looks nicer than "link(this)". But maintaining this doubles the size of Jump, which is even more unfortunate for the JIT, since there are many large structures holding JmpSrcs. Probably best to remove it.
Attachments
The patch (20.89 KB, patch)
2008-12-05 13:59 PST, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2008-12-05 13:59:31 PST
Created attachment 25787 [details] The patch
Geoffrey Garen
Comment 2 2008-12-05 14:10:11 PST
Comment on attachment 25787 [details] The patch r=me
Gavin Barraclough
Comment 3 2008-12-05 14:14:13 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/wrec/WREC.cpp Sending JavaScriptCore/wrec/WRECGenerator.cpp Sending JavaScriptCore/wrec/WRECParser.h Transmitting file data ..... Committed revision 39043.
Note You need to log in before you can comment on or make changes to this bug.