Bug 226925

Summary:

[check-webkit-style] failing in JS checker due to python byte string

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, dewei_zhu, ews-watchlist, glenn, hi, repstein, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Jonathan Bedard 2021-06-11 09:12:07 PDT

We read JS files in as binary, but then run string regexes against the binary content, which doesn't work.

Comment 1 Jonathan Bedard 2021-06-11 09:12:30 PDT

<rdar://problem/79166108>

Comment 2 Jonathan Bedard 2021-06-11 09:16:09 PDT

Created attachment 431204 [details]
Patch

Comment 3 Jonathan Bedard 2021-06-11 09:20:55 PDT

Created attachment 431205 [details]
Patch

Comment 4 Russell Epstein 2021-06-11 10:18:41 PDT

r=me

Comment 5 Jonathan Bedard 2021-06-11 10:34:45 PDT

Russell isn't a reviewer, so that "r+" is really an "unofficial r+"

Comment 6 EWS 2021-06-11 11:37:34 PDT

Committed r278771 (238730@main): <https://commits.webkit.org/238730@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431205 [details].

Comment 7 Ryan Haddad 2021-06-11 20:08:34 PDT

*** Bug 226904 has been marked as a duplicate of this bug. ***