Bug 226925

Summary: [check-webkit-style] failing in JS checker due to python byte string
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, hi, repstein, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2021-06-11 09:12:07 PDT
We read JS files in as binary, but then run string regexes against the binary content, which doesn't work.
Attachments
Patch (3.12 KB, patch)
2021-06-11 09:16 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.86 KB, patch)
2021-06-11 09:20 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2021-06-11 09:12:30 PDT
<rdar://problem/79166108>
Jonathan Bedard
Comment 2 2021-06-11 09:16:09 PDT
Created attachment 431204 [details] Patch
Jonathan Bedard
Comment 3 2021-06-11 09:20:55 PDT
Created attachment 431205 [details] Patch
Russell Epstein
Comment 4 2021-06-11 10:18:41 PDT
r=me
Jonathan Bedard
Comment 5 2021-06-11 10:34:45 PDT
Russell isn't a reviewer, so that "r+" is really an "unofficial r+"
EWS
Comment 6 2021-06-11 11:37:34 PDT
Committed r278771 (238730@main): <https://commits.webkit.org/238730@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431205 [details].
Ryan Haddad
Comment 7 2021-06-11 20:08:34 PDT
*** Bug 226904 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.