Bug 226920

Summary: GLES and EGL from ANGLE should link with libdl
Product: WebKit Reporter: Eleni Maria Stea <estea>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Eleni Maria Stea
Reported 2021-06-11 07:54:05 PDT
GLES and EGL that are generated from ANGLE should link with libdl because they use dlsym and dlopen. Also, initially I thought that we shouldn't link with libEGL when we use USE_ANGLE_WEBGL instead of USE_ANGLE_EGL because the symbols of EGL were found in generated libGLES. But with the new CMakeLists.txt I see that libEGL contains the right symbols and so, we can link with it in both cases.
Attachments
Patch (2.29 KB, patch)
2021-06-11 08:00 PDT, Eleni Maria Stea 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2021-06-11 08:27 PDT, Eleni Maria Stea 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eleni Maria Stea
Comment 1 2021-06-11 08:00:56 PDT
Created attachment 431194 [details] Patch
EWS Watchlist
Comment 2 2021-06-11 08:02:03 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Eleni Maria Stea
Comment 3 2021-06-11 08:27:37 PDT
Created attachment 431197 [details] Patch
Eleni Maria Stea
Comment 4 2021-06-11 08:29:50 PDT
[Update]: I've removed EGL from the case we use WEBGL and fixed -dl to be platform specific using the CMake variable (thanks Don Olmstead!).
Kenneth Russell
Comment 5 2021-06-11 10:33:51 PDT
Comment on attachment 431197 [details] Patch Looks good; r+.
EWS
Comment 6 2021-06-11 11:08:40 PDT
Committed r278768 (238727@main): <https://commits.webkit.org/238727@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431197 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-11 11:09:23 PDT
<rdar://problem/79207140>
Note You need to log in before you can comment on or make changes to this bug.