Summary: | [WinCairo] Can't open WebInspector UI since r277787 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebKit2 | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, don.olmstead, ews-watchlist, hi, jasemabeed114, joepeck, kkinnunen, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fujii Hironori
2021-06-10 18:10:25 PDT
Created attachment 431164 [details]
WIP patch
Created attachment 431165 [details]
Patch
Comment on attachment 431165 [details] Patch Clearing flags on attachment: 431165 Committed r278748 (238709@main): <https://commits.webkit.org/238709@main> All reviewed patches have been landed. Closing bug. Comment on attachment 431165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review > Source/WebKit/ChangeLog:13 > + InspectorResourceURLSchemeHandler::platformStartTask shouldn't > + hold the reference of the temporary object. What is the problem with that? Is it a bug in the compiler that you use? Comment on attachment 431165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review >> Source/WebKit/ChangeLog:13 >> + hold the reference of the temporary object. > > What is the problem with that? Is it a bug in the compiler that you use? This is not a compiler issue. task.request() returns a ResourceRequest object. task.request().url() returns a URL of it. However, the ResourceRequest object is destructed on the end of the line. I see, so it's ResourceRequest that is the temporary object, not the URL. Makes sense. |