Bug 226908

Summary: [WinCairo] Can't open WebInspector UI since r277787
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit2Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, don.olmstead, ews-watchlist, hi, jasemabeed114, joepeck, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Fujii Hironori
Reported 2021-06-10 18:10:25 PDT
[WinCairo][WK2] Can't open WebInspector UI since r277787 1. Start WinCairo WK2 MiniBrowser 2. Menu -> Develop -> Show Web Inspector Extected: Web Inspector appears. Actual: Nothing appears. r277787 (Bug 226001) changed the return type of WebURLSchemeTask::request() from const WebCore::ResourceRequest& to WebCore::ResourceRequest. InspectorResourceURLSchemeHandler::platformStartTask shouldn't hold the reference of temporary object.
Attachments
WIP patch (750 bytes, patch)
2021-06-10 18:21 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2021-06-10 18:35 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-06-10 18:21:02 PDT
Created attachment 431164 [details] WIP patch
Fujii Hironori
Comment 2 2021-06-10 18:35:12 PDT
Created attachment 431165 [details] Patch
Fujii Hironori
Comment 3 2021-06-10 19:36:49 PDT
Comment on attachment 431165 [details] Patch Clearing flags on attachment: 431165 Committed r278748 (238709@main): <https://commits.webkit.org/238709@main>
Fujii Hironori
Comment 4 2021-06-10 19:36:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2021-06-10 19:37:18 PDT
<rdar://problem/79174706>
Alexey Proskuryakov
Comment 6 2021-11-11 11:52:15 PST
Comment on attachment 431165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review > Source/WebKit/ChangeLog:13 > + InspectorResourceURLSchemeHandler::platformStartTask shouldn't > + hold the reference of the temporary object. What is the problem with that? Is it a bug in the compiler that you use?
Fujii Hironori
Comment 7 2021-11-11 12:04:24 PST
Comment on attachment 431165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review >> Source/WebKit/ChangeLog:13 >> + hold the reference of the temporary object. > > What is the problem with that? Is it a bug in the compiler that you use? This is not a compiler issue. task.request() returns a ResourceRequest object. task.request().url() returns a URL of it. However, the ResourceRequest object is destructed on the end of the line.
Alexey Proskuryakov
Comment 8 2021-11-11 12:34:29 PST
I see, so it's ResourceRequest that is the temporary object, not the URL. Makes sense.
Note You need to log in before you can comment on or make changes to this bug.