Bug 226908

Summary: [WinCairo] Can't open WebInspector UI since r277787
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit2Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, don.olmstead, drousso, ews-watchlist, jasemabeed114, joepeck, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Description Fujii Hironori 2021-06-10 18:10:25 PDT
[WinCairo][WK2] Can't open WebInspector UI since r277787

1. Start WinCairo WK2 MiniBrowser
2. Menu -> Develop -> Show Web Inspector

Extected: Web Inspector appears.
Actual: Nothing appears.

r277787 (Bug 226001) changed the return type of WebURLSchemeTask::request() 
from const WebCore::ResourceRequest& to WebCore::ResourceRequest.

InspectorResourceURLSchemeHandler::platformStartTask shouldn't
hold the reference of temporary object.
Comment 1 Fujii Hironori 2021-06-10 18:21:02 PDT
Created attachment 431164 [details]
WIP patch
Comment 2 Fujii Hironori 2021-06-10 18:35:12 PDT
Created attachment 431165 [details]
Patch
Comment 3 Fujii Hironori 2021-06-10 19:36:49 PDT
Comment on attachment 431165 [details]
Patch

Clearing flags on attachment: 431165

Committed r278748 (238709@main): <https://commits.webkit.org/238709@main>
Comment 4 Fujii Hironori 2021-06-10 19:36:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2021-06-10 19:37:18 PDT
<rdar://problem/79174706>
Comment 6 Alexey Proskuryakov 2021-11-11 11:52:15 PST
Comment on attachment 431165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review

> Source/WebKit/ChangeLog:13
> +        InspectorResourceURLSchemeHandler::platformStartTask shouldn't
> +        hold the reference of the temporary object.

What is the problem with that? Is it a bug in the compiler that you use?
Comment 7 Fujii Hironori 2021-11-11 12:04:24 PST
Comment on attachment 431165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review

>> Source/WebKit/ChangeLog:13
>> +        hold the reference of the temporary object.
> 
> What is the problem with that? Is it a bug in the compiler that you use?

This is not a compiler issue.
task.request() returns a ResourceRequest object.
task.request().url() returns a URL of it.
However, the ResourceRequest object is destructed on the end of the line.
Comment 8 Alexey Proskuryakov 2021-11-11 12:34:29 PST
I see, so it's ResourceRequest that is the temporary object, not the URL. Makes sense.