Bug 226905

Summary: [CMake][GTK][WPE] Improve error message when libsoup3 is not found
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, cgarcia, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, pnormand, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2021-06-10 16:25:47 PDT
The packaging bots have been failing to build for a while because SOUP3 is enabled by default and this bots don't have libsoup3 installed on the local jhbuild or the local distro CMake Error at /usr/share/cmake-3.16/Modules/FindPkgConfig.cmake:463 (message): A required package was not found Call Stack (most recent call first): /usr/share/cmake-3.16/Modules/FindPkgConfig.cmake:643 (_pkg_check_modules_internal) Source/cmake/FindLibSoup.cmake:45 (pkg_check_modules) Source/cmake/WebKitFindPackage.cmake:105 (_find_package) Source/cmake/OptionsGTK.cmake:216 (find_package) Source/cmake/WebKitCommon.cmake:216 (include) CMakeLists.txt:20 (include) https://build.webkit.org/#/builders/30/builds/127/steps/8/logs/stdio I think it will be an improvement to be more clear with this error.
Attachments
Patch (2.87 KB, patch)
2021-06-10 16:28 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2021-06-10 16:28:39 PDT
Created attachment 431159 [details] Patch
EWS
Comment 2 2021-06-10 21:52:31 PDT
Committed r278753 (238714@main): <https://commits.webkit.org/238714@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431159 [details].
Note You need to log in before you can comment on or make changes to this bug.