Bug 226880

Summary:

Another speculative build fix for Win32.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	keith_miller: review+

Description Mark Lam 2021-06-10 09:00:40 PDT

We're getting reports of "warning C4206: nonstandard extension used: translation unit is empty" turning into a build error on Win32 ports.  By design, we rely on #define flags to make some translation units empty.  Hence, we don't want this warning to turn into an error.

rdar://79124858

Comment 1 Mark Lam 2021-06-10 09:11:23 PDT

Created attachment 431088 [details]
proposed patch.

Comment 2 Mark Lam 2021-06-10 10:19:25 PDT

Thanks for the review.  Landed in r278711: <http://trac.webkit.org/r278711>.