Bug 226844

Summary: Create SPI file for Synapse so external builds will work.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2021-06-09 13:25:59 PDT
Create SPI file for Synapse so external builds will work.
Attachments
Patch (7.42 KB, patch)
2021-06-09 13:30 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (7.37 KB, patch)
2021-06-09 13:38 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.37 KB, patch)
2021-06-09 17:32 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-06-09 13:30:04 PDT
Created attachment 431001 [details] Patch
Tim Horton
Comment 2 2021-06-09 13:32:25 PDT
Comment on attachment 431001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431001&action=review > Source/WebKit/Platform/spi/Cocoa/SynapseSPI.h:28 > +#if ENABLE(APP_HIGHLIGHTS) Maybe this should be around the whole file? > Source/WebKit/WebKit.xcodeproj/project.pbxproj:6 > - objectVersion = 52; > + objectVersion = 54; Maybe revert this?
Megan Gardner
Comment 3 2021-06-09 13:38:13 PDT
Created attachment 431003 [details] Patch
Megan Gardner
Comment 4 2021-06-09 17:32:44 PDT
Created attachment 431032 [details] Patch for landing
EWS
Comment 5 2021-06-09 21:41:52 PDT
Committed r278691 (238665@main): <https://commits.webkit.org/238665@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431032 [details].
Radar WebKit Bug Importer
Comment 6 2021-06-09 21:42:17 PDT
<rdar://problem/79119805>
Note You need to log in before you can comment on or make changes to this bug.