Summary: | [LayoutTests] Delete unused LayoutTests/tiled-drawing resources | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Jenner <jenner> | ||||||||
Component: | Tools / Tests | Assignee: | Robert Jenner <jenner> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | jbedard, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Robert Jenner
2021-06-09 12:54:07 PDT
Created attachment 430997 [details]
Patch
Comment on attachment 430997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430997&action=review > LayoutTests/ChangeLog:8 > + Delete unused php resources after tests were converted to python. This doesn't look like a PHP resource, looks like a normal resource, no? To clarify, this applies to all un-used resources, not just php. I was initially under the impression that this was only to remove unused php resources, but the script actually removed all un-used resources. For this one, the patch looks good, so I will r? it. Comment on attachment 430997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430997&action=review >> LayoutTests/ChangeLog:8 >> + Delete unused php resources after tests were converted to python. > > This doesn't look like a PHP resource, looks like a normal resource, no? Let's remove this comment Created attachment 431102 [details]
Patch
Created attachment 431110 [details]
Patch
Committed r278795 (238752@main): <https://commits.webkit.org/238752@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431110 [details]. |