Bug 226842

Summary: [LayoutTests] Delete unused LayoutTests/tiled-drawing resources
Product: WebKit Reporter: Robert Jenner <jenner>
Component: Tools / TestsAssignee: Robert Jenner <jenner>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Robert Jenner
Reported 2021-06-09 12:54:07 PDT
There are a number of unused resources in LayoutTests/tiled-drawing, we should delete them.
Attachments
Patch (5.58 KB, patch)
2021-06-09 12:56 PDT, Robert Jenner 		no flags
DetailsFormatted DiffDiff
Patch (5.70 KB, patch)
2021-06-10 11:47 PDT, Robert Jenner 		no flags
DetailsFormatted DiffDiff
Patch (5.47 KB, patch)
2021-06-10 12:43 PDT, Robert Jenner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-09 12:54:46 PDT
<rdar://problem/79093409>
Robert Jenner
Comment 2 2021-06-09 12:56:15 PDT
Created attachment 430997 [details] Patch
Jonathan Bedard
Comment 3 2021-06-09 13:12:53 PDT
Comment on attachment 430997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430997&action=review > LayoutTests/ChangeLog:8 > + Delete unused php resources after tests were converted to python. This doesn't look like a PHP resource, looks like a normal resource, no?
Robert Jenner
Comment 4 2021-06-10 10:38:48 PDT
To clarify, this applies to all un-used resources, not just php. I was initially under the impression that this was only to remove unused php resources, but the script actually removed all un-used resources. For this one, the patch looks good, so I will r? it.
Jonathan Bedard
Comment 5 2021-06-10 10:42:18 PDT
Comment on attachment 430997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430997&action=review >> LayoutTests/ChangeLog:8 >> + Delete unused php resources after tests were converted to python. > > This doesn't look like a PHP resource, looks like a normal resource, no? Let's remove this comment
Robert Jenner
Comment 6 2021-06-10 11:47:49 PDT
Created attachment 431102 [details] Patch
Robert Jenner
Comment 7 2021-06-10 12:43:55 PDT
Created attachment 431110 [details] Patch
EWS
Comment 8 2021-06-11 16:39:30 PDT
Committed r278795 (238752@main): <https://commits.webkit.org/238752@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431110 [details].
Note You need to log in before you can comment on or make changes to this bug.