Bug 226840

Summary: [CMake] Make ANGLE library types configurable
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, estea, ews-watchlist, gyuyoung.kim, kbr, kondapallykalyan, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch none

Description Don Olmstead 2021-06-09 12:47:04 PDT 
Windows ports for sure want shared libraries but other ports may not want that.
Comment 1 Don Olmstead 2021-06-09 12:57:22 PDT 
Created attachment 430998 [details]
WIP Patch
Comment 2 EWS Watchlist 2021-06-09 12:58:55 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Don Olmstead 2021-06-09 15:53:17 PDT 
Created attachment 431021 [details]
Patch
Comment 4 Kenneth Russell 2021-06-09 16:00:38 PDT 
Comment on attachment 431021 [details]
Patch

If everything builds, looks good to me! r+
Comment 5 Eleni Maria Stea 2021-06-09 23:04:24 PDT 
Thanks a lot! It looks good to me (+r) but I need to modify a little bit the GTK port (WIP).
Comment 6 EWS 2021-06-10 13:17:26 PDT 
Committed r278726 (238689@main): <https://commits.webkit.org/238689@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431021 [details].