Bug 226840

Summary: [CMake] Make ANGLE library types configurable
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, estea, ews-watchlist, gyuyoung.kim, kbr, kondapallykalyan, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch none

Don Olmstead
Reported 2021-06-09 12:47:04 PDT
Windows ports for sure want shared libraries but other ports may not want that.
Attachments
WIP Patch (6.07 KB, patch)
2021-06-09 12:57 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (6.38 KB, patch)
2021-06-09 15:53 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-06-09 12:57:22 PDT
Created attachment 430998 [details] WIP Patch
EWS Watchlist
Comment 2 2021-06-09 12:58:55 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Don Olmstead
Comment 3 2021-06-09 15:53:17 PDT
Created attachment 431021 [details] Patch
Kenneth Russell
Comment 4 2021-06-09 16:00:38 PDT
Comment on attachment 431021 [details] Patch If everything builds, looks good to me! r+
Eleni Maria Stea
Comment 5 2021-06-09 23:04:24 PDT
Thanks a lot! It looks good to me (+r) but I need to modify a little bit the GTK port (WIP).
EWS
Comment 6 2021-06-10 13:17:26 PDT
Committed r278726 (238689@main): <https://commits.webkit.org/238689@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431021 [details].
Note You need to log in before you can comment on or make changes to this bug.