Bug 226805

Summary: Clean up scrollbar creation code in RenderLayerScrollableArea
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2021-06-08 21:55:55 PDT 
Clean up scrollbar creation code in RenderLayerScrollableArea
Comment 1 Simon Fraser (smfr) 2021-06-08 21:57:50 PDT 
Created attachment 430940 [details]
Patch
Comment 2 zalan 2021-06-09 06:52:44 PDT 
Comment on attachment 430940 [details]
Patch

Sometimes the nullopt value of optional<bool> puzzles me. It's not too bad here though.
Comment 3 EWS 2021-06-09 09:02:30 PDT 
Committed r278661 (238643@main): <https://commits.webkit.org/238643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430940 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-09 09:03:20 PDT 
<rdar://problem/79079650>
Comment 5 Alex Christensen 2021-06-09 09:47:47 PDT 
This seems to have broken the Windows build.
https://ews-build.webkit.org/#/builders/10/builds/95353
Comment 6 Simon Fraser (smfr) 2021-06-09 09:54:20 PDT 
Fixing
Comment 7 Simon Fraser (smfr) 2021-06-09 09:56:09 PDT 
Fixed in r278664.