Bug 226805

Summary: Clean up scrollbar creation code in RenderLayerScrollableArea
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2021-06-08 21:55:55 PDT
Clean up scrollbar creation code in RenderLayerScrollableArea
Attachments
Patch (14.91 KB, patch)
2021-06-08 21:57 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-06-08 21:57:50 PDT
Created attachment 430940 [details] Patch
alan
Comment 2 2021-06-09 06:52:44 PDT
Comment on attachment 430940 [details] Patch Sometimes the nullopt value of optional<bool> puzzles me. It's not too bad here though.
EWS
Comment 3 2021-06-09 09:02:30 PDT
Committed r278661 (238643@main): <https://commits.webkit.org/238643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430940 [details].
Radar WebKit Bug Importer
Comment 4 2021-06-09 09:03:20 PDT
<rdar://problem/79079650>
Alex Christensen
Comment 5 2021-06-09 09:47:47 PDT
This seems to have broken the Windows build. https://ews-build.webkit.org/#/builders/10/builds/95353
Simon Fraser (smfr)
Comment 6 2021-06-09 09:54:20 PDT
Fixing
Simon Fraser (smfr)
Comment 7 2021-06-09 09:56:09 PDT
Fixed in r278664.
Note You need to log in before you can comment on or make changes to this bug.