Bug 226788

Summary: Rely on SQLiteDatabase::setMaximumSize() for quota management in LocalStorageDatabase
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, kkinnunen, pascal, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226814
Bug Depends on:    
Bug Blocks: 226832    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-06-08 16:21:45 PDT
Rely on SQLiteDatabase::setMaximumSize() for quota management in LocalStorageDatabase. It simplifies the code a bit.
Attachments
Patch (5.98 KB, patch)
2021-06-08 16:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-08 16:23:39 PDT
Created attachment 430907 [details] Patch
Kimmo Kinnunen
Comment 2 2021-06-08 22:33:06 PDT
Comment on attachment 430907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430907&action=review looks good as far as I understand the part (which is not terribly much) > Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp:232 > + if (result == SQLITE_FULL) (Not specific to this patch, but I'd imagine this can happen in other operations too, such as the removeItem above.)
EWS
Comment 3 2021-06-09 00:02:48 PDT
Committed r278651 (238633@main): <https://commits.webkit.org/238633@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430907 [details].
Radar WebKit Bug Importer
Comment 4 2021-06-09 00:03:16 PDT
<rdar://problem/79060435>
Chris Dumez
Comment 5 2021-06-16 08:44:18 PDT
*** Bug 226814 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.