Bug 226788

Summary:

Rely on SQLiteDatabase::setMaximumSize() for quota management in LocalStorageDatabase

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ggaren, kkinnunen, pascal, sihui_liu, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226814

Bug Depends on:

Bug Blocks:

226832

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2021-06-08 16:21:45 PDT

Rely on SQLiteDatabase::setMaximumSize() for quota management in LocalStorageDatabase. It simplifies the code a bit.

Comment 1 Chris Dumez 2021-06-08 16:23:39 PDT

Created attachment 430907 [details]
Patch

Comment 2 Kimmo Kinnunen 2021-06-08 22:33:06 PDT

Comment on attachment 430907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430907&action=review

looks good as far as I understand the part (which is not terribly much)

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp:232
> +        if (result == SQLITE_FULL)

(Not specific to this patch, but I'd imagine this can happen in other operations too, such as the removeItem above.)

Comment 3 EWS 2021-06-09 00:02:48 PDT

Committed r278651 (238633@main): <https://commits.webkit.org/238633@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430907 [details].

Comment 4 Radar WebKit Bug Importer 2021-06-09 00:03:16 PDT

<rdar://problem/79060435>

Comment 5 Chris Dumez 2021-06-16 08:44:18 PDT

*** Bug 226814 has been marked as a duplicate of this bug. ***