Bug 226768

Summary: Move some hand rolled CSSProperty predicates to be generated based on new CSSProperties.json properties
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, joepeck, koivisto, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2021-06-08 07:41:18 PDT
Move some hand rolled CSSProperty predicates to be generated based on new CSSProperties.json properties
Attachments
Patch (34.11 KB, patch)
2021-06-08 07:45 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-06-08 07:45:27 PDT
Created attachment 430840 [details] Patch
Antti Koivisto
Comment 2 2021-06-08 07:57:18 PDT
Comment on attachment 430840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430840&action=review > Source/WebCore/css/CSSProperties.json:101 > + "CSSProperty::isDescriptorOnly().", Wonder if should make these standalone functions...
EWS
Comment 3 2021-06-08 09:35:16 PDT
Committed r278611 (238600@main): <https://commits.webkit.org/238600@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430840 [details].
Radar WebKit Bug Importer
Comment 4 2021-06-08 09:36:20 PDT
<rdar://problem/79015696>
Note You need to log in before you can comment on or make changes to this bug.