Bug 226748

Summary: Drop legacy EventLoopEventQueue class
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, calvaris, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, peng.liu6, philipj, rniwa, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-06-07 17:45:38 PDT
Drop legacy EventLoopEventQueue class and have HTMLMediaElement use the HTML event loop directly.
Attachments
Patch (37.50 KB, patch)
2021-06-08 09:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.40 KB, patch)
2021-06-08 09:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (43.68 KB, patch)
2021-06-08 10:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (43.95 KB, patch)
2021-06-08 10:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (44.61 KB, patch)
2021-06-08 11:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (46.61 KB, patch)
2021-06-08 11:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (48.06 KB, patch)
2021-06-08 11:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (48.08 KB, patch)
2021-06-08 18:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-08 09:49:46 PDT
Created attachment 430852 [details] Patch
Chris Dumez
Comment 2 2021-06-08 09:59:16 PDT
Created attachment 430854 [details] Patch
Chris Dumez
Comment 3 2021-06-08 10:28:41 PDT
Created attachment 430858 [details] Patch
Chris Dumez
Comment 4 2021-06-08 10:40:59 PDT
Created attachment 430861 [details] Patch
Chris Dumez
Comment 5 2021-06-08 11:01:42 PDT
Created attachment 430864 [details] Patch
Chris Dumez
Comment 6 2021-06-08 11:08:24 PDT
Created attachment 430865 [details] Patch
Chris Dumez
Comment 7 2021-06-08 11:35:20 PDT
Created attachment 430869 [details] Patch
Darin Adler
Comment 8 2021-06-08 18:19:51 PDT
Comment on attachment 430869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430869&action=review > Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:48 > - *reason = "TextTrackCue is firing event listeners"; > + *reason = "ActiveDOMObject with pending activity"; Why is it better to have this message be vague? Can we share this constant string "ActiveDOMObject with pending activity" with uses elsewhere? > Source/WebCore/html/track/DataCue.cpp:75 > + dataCue->suspendIfNeeded(); A little frustrating to have to add so much boilerplate with all these calls.
Chris Dumez
Comment 9 2021-06-08 18:21:53 PDT
Comment on attachment 430869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430869&action=review >> Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:48 >> + *reason = "ActiveDOMObject with pending activity"; > > Why is it better to have this message be vague? > > Can we share this constant string "ActiveDOMObject with pending activity" with uses elsewhere? I copied the code from the generated bindings code for [ActiveDOMObject]. I don't have to keep the message so generic though, I'll replace ActiveDOMObject with TextTrackCue.
Chris Dumez
Comment 10 2021-06-08 18:29:23 PDT
Created attachment 430931 [details] Patch
EWS
Comment 11 2021-06-08 21:33:12 PDT
Committed r278645 (238627@main): <https://commits.webkit.org/238627@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430931 [details].
Radar WebKit Bug Importer
Comment 12 2021-06-08 21:34:19 PDT
<rdar://problem/79054988>
Note You need to log in before you can comment on or make changes to this bug.