| Summary: | Drop legacy EventLoopEventQueue class | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||
| Component: | Media | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | annulen, calvaris, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, peng.liu6, philipj, rniwa, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Chris Dumez
2021-06-07 17:45:38 PDT
Created attachment 430852 [details]
Patch
Created attachment 430854 [details]
Patch
Created attachment 430858 [details]
Patch
Created attachment 430861 [details]
Patch
Created attachment 430864 [details]
Patch
Created attachment 430865 [details]
Patch
Created attachment 430869 [details]
Patch
Comment on attachment 430869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430869&action=review > Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:48 > - *reason = "TextTrackCue is firing event listeners"; > + *reason = "ActiveDOMObject with pending activity"; Why is it better to have this message be vague? Can we share this constant string "ActiveDOMObject with pending activity" with uses elsewhere? > Source/WebCore/html/track/DataCue.cpp:75 > + dataCue->suspendIfNeeded(); A little frustrating to have to add so much boilerplate with all these calls. Comment on attachment 430869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430869&action=review >> Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:48 >> + *reason = "ActiveDOMObject with pending activity"; > > Why is it better to have this message be vague? > > Can we share this constant string "ActiveDOMObject with pending activity" with uses elsewhere? I copied the code from the generated bindings code for [ActiveDOMObject]. I don't have to keep the message so generic though, I'll replace ActiveDOMObject with TextTrackCue. Created attachment 430931 [details]
Patch
Committed r278645 (238627@main): <https://commits.webkit.org/238627@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430931 [details]. |