Bug 226736

Summary: [Modern Media Controls] upstream new features
Product: WebKit Reporter: Devin Rousso <hi>
Component: MediaAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, benjamin, calvaris, cdumez, changseok, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, jer.noble, joepeck, kondapallykalyan, megan_gardner, pdr, peng.liu6, philipj, sergio, thorton, tsavell, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=271785
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Devin Rousso
Reported 2021-06-07 12:22:26 PDT
.
Attachments
Patch (36.22 KB, patch)
2021-06-07 14:09 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (36.24 KB, patch)
2021-06-07 23:50 PDT, Devin Rousso 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-07 12:22:42 PDT
<rdar://problem/78957464>
Devin Rousso
Comment 2 2021-06-07 14:09:37 PDT
Created attachment 430777 [details] Patch
Peng Liu
Comment 3 2021-06-07 15:59:35 PDT
Comment on attachment 430777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430777&action=review > LayoutTests/platform/mac-wk2/TestExpectations:22 > +media/modern-media-controls/overflow-support [ Pass ] Can we enable the test for iOS as well?
Devin Rousso
Comment 4 2021-06-07 16:02:19 PDT
Comment on attachment 430777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430777&action=review >> LayoutTests/platform/mac-wk2/TestExpectations:22 >> +media/modern-media-controls/overflow-support [ Pass ] > > Can we enable the test for iOS as well? iOS requires some new functionality that's not yet in EWS bots (see `#define ENABLE_MEDIA_CONTROLS_CONTEXT_MENUS`). These tests are enabled on the internal bots in the meantime.
Eric Carlson
Comment 5 2021-06-07 16:05:26 PDT
Comment on attachment 430777 [details] Patch r=me once the bots agree
Devin Rousso
Comment 6 2021-06-07 23:50:12 PDT
Created attachment 430814 [details] Patch just tried building with the latest public SDK in an effort to match the bots and the test passed just fine :/
EWS
Comment 7 2021-06-08 10:27:40 PDT
Committed r278618 (238603@main): <https://commits.webkit.org/238603@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430814 [details].
Truitt Savell
Comment 8 2021-06-09 10:24:49 PDT
the new test media/modern-media-controls/overflow-support/chapters.html added in https://trac.webkit.org/changeset/278618/webkit is a constant timeout: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Foverflow-support%2Fchapters.html This is impeding ews, can this be fixed quickly or can we revert this change until it is fixed? Tracking bug: https://bugs.webkit.org/show_bug.cgi?id=226828
Note You need to log in before you can comment on or make changes to this bug.