Summary: | [css-flexbox] Tables inside flexbox do not account for their borders correctly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Felipe Erias <felipeerias> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED CONFIGURATION CHANGED | ||||||||
Severity: | Normal | CC: | ahmad.saleem792, bfulgham, changseok, esprehn+autocc, ews-watchlist, felipeerias, glenn, kondapallykalyan, pdr, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Felipe Erias
2021-06-07 07:27:41 PDT
Created attachment 430745 [details]
Patch
Created attachment 431181 [details]
Patch
Updated the title because this turned out to be a more general problem. When a table's height or width is set though an attribute of the <table> tag, that value will include borders and padding. When it is set through CSS, that will depend on the value of the table's "box-sizing" property. With the last patch, RenderTable will check for the presence of those attributes in the <table> tag as well as the value of "box-sizing" before deciding how to handle the table's border and padding. This fixes: imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html I suspect that table-as-item-inflexible-in-column-2.html also fails for a similar reason. Comment on attachment 431181 [details]
Patch
Cleaning r? flag, since it does not build, and it is quite old at this point.
Safari Technology Preview 172 is passing both tests: https://wpt.fyi/results/css/css-flexbox?label=master&label=experimental&aligned=&q=table-as-item-inflexible-in-column Do we need to track this anymore? Closing based on Ahmad's testing. |