Bug 226714

Summary: [GStreamer] Remove spurious assert in WTF::DataMutex
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bugs-noreply, calvaris, cdumez, cmarcelo, ews-watchlist, fujii.hironori, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Alicia Boya García
Reported 2021-06-07 01:44:08 PDT
Remove DATA_MUTEX_CHECK(!mutex().isHeld()); from the DataMutexLocker constructor, introduced in r278248. Trying to lock a currently held mutex is not an error condition that should crash the process, it will just wait for its turn to lock it.
Attachments
Patch (1.34 KB, patch)
2021-06-07 01:44 PDT, Alicia Boya García 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2021-06-07 01:44:52 PDT
Created attachment 430725 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2021-06-07 04:27:25 PDT
lgtm
EWS
Comment 3 2021-06-07 04:40:57 PDT
Committed r278555 (238553@main): <https://commits.webkit.org/238553@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430725 [details].
Fujii Hironori
Comment 4 2021-06-16 18:52:26 PDT
This change causes a test failure. Bug 227021 – [GTK] TestWTF:WTF_DataMutex.DoubleLockDeathTest is timing out
Note You need to log in before you can comment on or make changes to this bug.