Bug 22671

Summary:

Port the JIT to use the MacroAssembler, stage 1 of N.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
The patch	ggaren: review+

Gavin Barraclough

Reported 2008-12-04 21:44:21 PST

Note to self: come back later, edit the bug, update the value of N – look like you totally guessed ahead oh time how many patches this would take.

Attachments
The patch (42.59 KB, patch) 2008-12-04 22:08 PST, Gavin Barraclough	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2008-12-04 22:08:04 PST

Created attachment 25761 [details] The patch

Geoffrey Garen

Comment 2 2008-12-04 22:18:36 PST

Comment on attachment 25761 [details] The patch r=me Personally, I don't think we gain anything by changing things like "mov" and "jo" in the assembler to "move" and "jover" in the macro assembler. I think "jzSub32" and "joAdd32" are probably better names than "jzeroSub32" and "joverAdd32."

Gavin Barraclough

Comment 3 2008-12-04 22:59:24 PST

Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/jit/JIT.cpp Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITArithmetic.cpp Sending JavaScriptCore/jit/JITInlineMethods.h Sending JavaScriptCore/jit/JITPropertyAccess.cpp Transmitting file data ........ Committed revision 39020.

Note You need to log in before you can comment on or make changes to this bug.