Bug 226684

Summary: Unexport llvm coverage symbols to fix build
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226562    
Bug Blocks: 228063    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2021-06-05 08:28:02 PDT
Unexport llvm coverage symbols to fix build Even after the fix in r278444 for Bug 226562, some internal projects still failed to build during the GenerateTAPI build phase: error: headers don't have symbol '(weak-def) ___llvm_profile_filename' error: headers don't have symbol '(weak-def) ___llvm_profile_raw_version' error: headers don't have symbol '(weak-def) _lprofDirMode' So instead of just ignoring these weak external symbols in check-for-weak-vtables-and-externals, we need to unexport them.
Attachments
Patch v1 (2.77 KB, patch)
2021-06-05 08:33 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-05 08:28:26 PDT
<rdar://problem/78906691>
David Kilzer (:ddkilzer)
Comment 2 2021-06-05 08:33:16 PDT
Created attachment 430650 [details] Patch v1
EWS
Comment 3 2021-06-06 07:47:41 PDT
Committed r278536 (238534@main): <https://commits.webkit.org/238534@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430650 [details].
David Kilzer (:ddkilzer)
Comment 4 2021-06-17 08:55:08 PDT
(In reply to EWS from comment #3) > Committed r278536 (238534@main): <https://commits.webkit.org/238534@main> Follow-up fix for wrong comment character in Tools/coverage/coverage.xcconfig file: Committed r278536: <https://trac.webkit.org/r278536>
David Kilzer (:ddkilzer)
Comment 5 2021-06-17 08:56:06 PDT
(In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to EWS from comment #3) > > Committed r278536 (238534@main): <https://commits.webkit.org/238534@main> > > Follow-up fix for wrong comment character in > Tools/coverage/coverage.xcconfig file: > > Committed r278536: <https://trac.webkit.org/r278536> Committed r278987: <https://trac.webkit.org/r278987> (Copied and pasted the wrong commit revision!)
Note You need to log in before you can comment on or make changes to this bug.