Bug 226674

Summary:

Optimize a few call sites creating SharedBuffer objects

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, darin, eric.carlson, ews-watchlist, glenn, hi, hta, jer.noble, joepeck, philipj, sam, sergio, tommyw, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-

Description Chris Dumez 2021-06-04 20:43:11 PDT

Optimization a few call sites creating SharedBuffer objects.

Comment 1 Chris Dumez 2021-06-04 20:44:53 PDT

Created attachment 430640 [details]
Patch

Comment 2 Darin Adler 2021-06-04 21:18:02 PDT

Comment on attachment 430640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430640&action=review

> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:-1249
> -        overrideData = SharedBuffer::create(content.utf8().data(), content.utf8().length());

Wow, we should grep for this mistake, even when it doesn’t involve SharedBuffer.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1651
> +    auto sharedBuffer = SharedBuffer::create(data.data(), data.size());

Seems a little sad that we copy in all these IPC cases. But I guess getting lifetime right would be tricky if we used more of a data view instead of a copy.

Comment 3 EWS 2021-06-04 22:46:03 PDT

Committed r278523 (238522@main): <https://commits.webkit.org/238522@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430640 [details].

Comment 4 Radar WebKit Bug Importer 2021-06-04 22:47:15 PDT

<rdar://problem/78899496>