Bug 226658

Summary:

[run-webkit-tests] Use Python 3

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, clopez, dewei_zhu, ews-watchlist, glenn, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=225427
https://bugs.webkit.org/show_bug.cgi?id=227715
https://bugs.webkit.org/show_bug.cgi?id=221043
https://bugs.webkit.org/show_bug.cgi?id=229172
https://bugs.webkit.org/show_bug.cgi?id=229360
https://bugs.webkit.org/show_bug.cgi?id=229783
https://bugs.webkit.org/show_bug.cgi?id=237404

Bug Depends on:

230513

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Part 1	none
Patch	none
Run with 3 test	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Testing Patch	none
Part 2	none
Testing Patch	ews-feeder: commit-queue-
Testing Patch	ews-feeder: commit-queue-
Testing Patch	none
[fast-cq] Patch	none
[fast-cq] Patch	none
Patch	none
Patch	none
Patch	none

Jonathan Bedard

Reported 2021-06-04 13:03:54 PDT

Now that run-webkit-tests is compatible with Python 3.8, we should use Python 3 for run-webkit-tests.

Attachments
Patch (24.59 KB, patch) 2021-06-04 13:08 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Part 1 (1005 bytes, patch) 2021-06-30 10:45 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (24.09 KB, patch) 2021-06-30 11:09 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Run with 3 test (4.60 KB, patch) 2021-07-01 08:43 PDT, Jonathan Bedard	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.54 KB, patch) 2021-08-16 11:11 PDT, Jonathan Bedard	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (5.93 KB, patch) 2021-08-16 14:59 PDT, Jonathan Bedard	ews-feeder: commit-queue-	Details Formatted Diff Diff
Testing Patch (6.25 KB, patch) 2021-08-16 16:47 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Part 2 (26.27 KB, patch) 2021-08-17 08:32 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Testing Patch (5.12 KB, patch) 2021-08-17 15:33 PDT, Jonathan Bedard	ews-feeder: commit-queue-	Details Formatted Diff Diff
Testing Patch (5.60 KB, patch) 2021-08-18 10:42 PDT, Jonathan Bedard	ews-feeder: commit-queue-	Details Formatted Diff Diff
Testing Patch (17.51 KB, patch) 2021-08-20 17:42 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
[fast-cq] Patch (7.91 KB, patch) 2021-08-26 09:14 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
[fast-cq] Patch (20.29 KB, patch) 2021-08-26 09:16 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (26.36 KB, patch) 2021-09-24 17:04 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (26.35 KB, patch) 2021-09-24 17:08 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (4.11 KB, patch) 2022-02-09 16:55 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (14) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-06-04 13:04:29 PDT

<rdar://problem/78882016>

Jonathan Bedard

Comment 2 2021-06-04 13:08:59 PDT

Created attachment 430602 [details] Patch

Jonathan Bedard

Comment 3 2021-06-04 13:16:20 PDT

Probably needs to be tested at the same time as https://bugs.webkit.org/show_bug.cgi?id=225427, they are doing something very similar

Jonathan Bedard

Comment 4 2021-06-30 10:45:14 PDT

Created attachment 432609 [details] Part 1

Jonathan Bedard

Comment 5 2021-06-30 11:09:51 PDT

Created attachment 432612 [details] Patch

Jonathan Bedard

Comment 6 2021-07-01 08:43:55 PDT

Created attachment 432699 [details] Run with 3 test

Carlos Alberto Lopez Perez

Comment 7 2021-07-08 17:24:56 PDT

is this waiting for review? why not squash all the 3 commits into 1?

Aakash Jain

Comment 8 2021-07-09 08:21:29 PDT

(In reply to Carlos Alberto Lopez Perez from comment #7) > is this waiting for review? why not squash all the 3 commits into 1? Nope. It's waiting for more testing.

Jonathan Bedard

Comment 9 2021-07-12 08:41:09 PDT

(In reply to Carlos Alberto Lopez Perez from comment #7) > is this waiting for review? why not squash all the 3 commits into 1? Just some clarification, the 3rd patch is not meant for landing, it's just a way for me to force EWS to use Python 3 since buildbot invokes run-webkit-tests with Python 2 directly.

Jonathan Bedard

Comment 10 2021-08-16 11:11:21 PDT

Created attachment 435620 [details] Patch

Jonathan Bedard

Comment 11 2021-08-16 14:59:36 PDT

Created attachment 435632 [details] Patch

Jonathan Bedard

Comment 12 2021-08-16 16:47:10 PDT

Created attachment 435643 [details] Testing Patch

Jonathan Bedard

Comment 13 2021-08-17 08:32:58 PDT

Created attachment 435689 [details] Part 2

Aakash Jain

Comment 14 2021-08-17 13:15:42 PDT

https://ews-build.webkit.org/#/builders/10/builds/101763 (windows) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/common/system/abstractexecutive.py", line 111, in command_for_printing return string_utils.decode(string_utils.encode(' '.join(args), encoding='unicode_escape')) TypeError: sequence item 0: expected str instance, bytes found

Jonathan Bedard

Comment 15 2021-08-17 15:33:05 PDT

Created attachment 435716 [details] Testing Patch

Jonathan Bedard

Comment 16 2021-08-18 10:42:36 PDT

Created attachment 435782 [details] Testing Patch

Jonathan Bedard

Comment 17 2021-08-20 17:42:56 PDT

Created attachment 436049 [details] Testing Patch

dewei_zhu

Comment 18 2021-08-24 16:02:52 PDT

Comment on attachment 432609 [details] Part 1 r=me