| Summary: | [run-webkit-tests] Use Python 3 | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||||||||||||||||||||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, clopez, dewei_zhu, ews-watchlist, glenn, webkit-bug-importer | ||||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=225427 https://bugs.webkit.org/show_bug.cgi?id=227715 https://bugs.webkit.org/show_bug.cgi?id=221043 https://bugs.webkit.org/show_bug.cgi?id=229172 https://bugs.webkit.org/show_bug.cgi?id=229360 https://bugs.webkit.org/show_bug.cgi?id=229783 https://bugs.webkit.org/show_bug.cgi?id=237404 |
||||||||||||||||||||||||||||||||||||
| Bug Depends on: | 230513 | ||||||||||||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||
|
Description
Jonathan Bedard
2021-06-04 13:03:54 PDT
Created attachment 430602 [details]
Patch
Probably needs to be tested at the same time as https://bugs.webkit.org/show_bug.cgi?id=225427, they are doing something very similar Created attachment 432609 [details]
Part 1
Created attachment 432612 [details]
Patch
Created attachment 432699 [details]
Run with 3 test
is this waiting for review? why not squash all the 3 commits into 1? (In reply to Carlos Alberto Lopez Perez from comment #7) > is this waiting for review? why not squash all the 3 commits into 1? Nope. It's waiting for more testing. (In reply to Carlos Alberto Lopez Perez from comment #7) > is this waiting for review? why not squash all the 3 commits into 1? Just some clarification, the 3rd patch is not meant for landing, it's just a way for me to force EWS to use Python 3 since buildbot invokes run-webkit-tests with Python 2 directly. Created attachment 435620 [details]
Patch
Created attachment 435632 [details]
Patch
Created attachment 435643 [details]
Testing Patch
Created attachment 435689 [details]
Part 2
https://ews-build.webkit.org/#/builders/10/builds/101763 (windows) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/common/system/abstractexecutive.py", line 111, in command_for_printing return string_utils.decode(string_utils.encode(' '.join(args), encoding='unicode_escape')) TypeError: sequence item 0: expected str instance, bytes found Created attachment 435716 [details]
Testing Patch
Created attachment 435782 [details]
Testing Patch
Created attachment 436049 [details]
Testing Patch
Comment on attachment 432609 [details]
Part 1
r=me
Committed r281528 (240900@main): <https://commits.webkit.org/240900@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432609 [details]. Reopening to attach new patch. Created attachment 436518 [details]
[fast-cq] Patch
Created attachment 436519 [details]
[fast-cq] Patch
Committed r281627 (240983@main): <https://commits.webkit.org/240983@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436518 [details]. . Reopened for landing attachment 436519 [details].
Committed r281690 (241040@main): <https://commits.webkit.org/241040@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436519 [details]. buildbot on EWS and build.webkit.org has been restarted to pick up this change. Blocked by https://bugs.webkit.org/show_bug.cgi?id=230513, as it turns out. Created attachment 439214 [details]
Patch
Created attachment 439216 [details]
Patch
Committed r283071 (242129@main): <https://commits.webkit.org/242129@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439216 [details]. Blocked by https://bugs.webkit.org/show_bug.cgi?id=230513 at the moment Created attachment 451466 [details]
Patch
Pull request: https://github.com/WebKit/WebKit/pull/160 Re-opening for pull request https://github.com/WebKit/WebKit/pull/165 Pull request: https://github.com/WebKit/WebKit/pull/167 |