Bug 226656

Summary:

[JSC] Private static method should define privateClassBrandIdentifier in class-scope

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Yusuke Suzuki 2021-06-04 12:33:48 PDT

[JSC] Private static method should define privateClassBrandIdentifier in class-scope

Comment 1 Yusuke Suzuki 2021-06-04 12:34:57 PDT

Created attachment 430598 [details]
Patch

Comment 2 Yusuke Suzuki 2021-06-04 12:34:59 PDT

<rdar://problem/78313139>

Comment 3 EWS 2021-06-04 16:44:30 PDT

Committed r278510 (238509@main): <https://commits.webkit.org/238509@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430598 [details].

Comment 4 Caio Lima 2021-06-07 12:25:57 PDT

Comment on attachment 430598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430598&action=review

> Source/JavaScriptCore/parser/Parser.cpp:3036
> +                    declaresStaticPrivateMethod = true;

OOPS, nice catch there.