Bug 226656 - [JSC] Private static method should define privateClassBrandIdentifier in class-scope
Summary: [JSC] Private static method should define privateClassBrandIdentifier in clas...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-04 12:33 PDT by Yusuke Suzuki
Modified: 2021-06-07 12:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.50 KB, patch)
2021-06-04 12:34 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-06-04 12:33:48 PDT 
[JSC] Private static method should define privateClassBrandIdentifier in class-scope
Comment 1 Yusuke Suzuki 2021-06-04 12:34:57 PDT 
Created attachment 430598 [details]
Patch
Comment 2 Yusuke Suzuki 2021-06-04 12:34:59 PDT 
<rdar://problem/78313139>
Comment 3 EWS 2021-06-04 16:44:30 PDT 
Committed r278510 (238509@main): <https://commits.webkit.org/238509@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430598 [details].
Comment 4 Caio Lima 2021-06-07 12:25:57 PDT 
Comment on attachment 430598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430598&action=review

> Source/JavaScriptCore/parser/Parser.cpp:3036
> +                    declaresStaticPrivateMethod = true;

OOPS, nice catch there.