Bug 226642

Summary: The CMake cache is removed when specifying a build target
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: CMakeAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Martin Robinson
Reported 2021-06-04 06:12:14 PDT
When specifying a build target to build-webkit, for example running `build-webkit --gtk --release bin/MiniBrowser`, the addition of the build target causes build-webkit to delete the CMake cache. In this case, it really shouldn't be doing that. Only arguments which change the build configuration should trigger the removal of the cache.
Attachments
Patch (1.51 KB, patch)
2021-06-04 06:13 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2021-06-04 06:35 PDT, Martin Robinson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-06-04 06:13:07 PDT
Created attachment 430571 [details] Patch
Martin Robinson
Comment 2 2021-06-04 06:35:45 PDT
Created attachment 430572 [details] Patch
EWS
Comment 3 2021-06-04 08:35:37 PDT
Committed r278460 (238480@main): <https://commits.webkit.org/238480@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430572 [details].
Note You need to log in before you can comment on or make changes to this bug.