Bug 226642

Summary: The CMake cache is removed when specifying a build target
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: CMakeAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Description Martin Robinson 2021-06-04 06:12:14 PDT 
When specifying a build target to build-webkit, for example running `build-webkit --gtk --release bin/MiniBrowser`, the addition of the build target causes build-webkit to delete the CMake cache. In this case, it really shouldn't be doing that. Only arguments which change the build configuration should trigger the removal of the cache.
Comment 1 Martin Robinson 2021-06-04 06:13:07 PDT 
Created attachment 430571 [details]
Patch
Comment 2 Martin Robinson 2021-06-04 06:35:45 PDT 
Created attachment 430572 [details]
Patch
Comment 3 EWS 2021-06-04 08:35:37 PDT 
Committed r278460 (238480@main): <https://commits.webkit.org/238480@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430572 [details].