Summary: | [Cairo] Fix Path::boundingRectSlowCase when the path is a single MoveTo | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arcady Goldmints-Orlov <crzwdjk> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cgarcia, Hironori.Fujii, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Arcady Goldmints-Orlov
2021-06-03 17:45:36 PDT
Created attachment 430520 [details]
Patch
I have questions. Which benchmark are you using? How does it improve? Why is it using the single move paths? Why is cairo_path_extents slower for the case? Oops. I misread and misunderstood. This is not a speed-up, but a bug fix. Do you have a test case? Comment on attachment 430520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430520&action=review > Source/WebCore/ChangeLog:7 > + Could you explain here what's wrong exactly. Are we rendering anything incorrectly? does this fix any test? or can we add a new one? > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:414 > + if (m_elements && m_elements.value().size() == 1 > + && m_elements.value()[0].type == PathElement::Type::MoveToPoint) { This could be a single line. Comment on attachment 430520 [details] Patch r- for comment#4. Sorry, I should have been clearer. This fixes the new fast/svg/bounding-rect-for-path-with-only-move-command.html test which was added recently, I will add that to the changelog, and fix the formatting issue. Thanks for taking a look. Created attachment 430981 [details]
Patch
Created attachment 431000 [details]
Patch
Committed r278730 (238693@main): <https://commits.webkit.org/238693@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431000 [details]. |