Bug 226604

Summary: DFG should eliminate obvious store barriers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mark.lam: review+

Description Filip Pizlo 2021-06-03 15:01:03 PDT 
We have a store barrier elimination strategy mostly based on "clustering" -- moving the barriers to the point where they will actually be meaningful.

Unfortunately, we have PutByOffset listed as DoesGC, so we will not eliminate any store barriers around sequences of PutByOffsets.  This appears to be the case because PutByOffset was accidentally added to the DoesGC list in r240991.
Comment 1 Filip Pizlo 2021-06-03 15:04:18 PDT 
Created attachment 430504 [details]
the patch
Comment 2 Mark Lam 2021-06-03 15:12:35 PDT 
Comment on attachment 430504 [details]
the patch

r=me
Comment 3 Filip Pizlo 2021-06-03 15:28:03 PDT 
Landed in https://trac.webkit.org/changeset/278424/webkit
Comment 4 Radar WebKit Bug Importer 2021-06-03 15:29:22 PDT 
<rdar://problem/78839959>