Bug 226604

Summary: DFG should eliminate obvious store barriers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2021-06-03 15:01:03 PDT
We have a store barrier elimination strategy mostly based on "clustering" -- moving the barriers to the point where they will actually be meaningful. Unfortunately, we have PutByOffset listed as DoesGC, so we will not eliminate any store barriers around sequences of PutByOffsets. This appears to be the case because PutByOffset was accidentally added to the DoesGC list in r240991.
Attachments
the patch (3.41 KB, patch)
2021-06-03 15:04 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2021-06-03 15:04:18 PDT
Created attachment 430504 [details] the patch
Mark Lam
Comment 2 2021-06-03 15:12:35 PDT
Comment on attachment 430504 [details] the patch r=me
Filip Pizlo
Comment 3 2021-06-03 15:28:03 PDT
Landed in https://trac.webkit.org/changeset/278424/webkit
Radar WebKit Bug Importer
Comment 4 2021-06-03 15:29:22 PDT
<rdar://problem/78839959>
Note You need to log in before you can comment on or make changes to this bug.