Bug 226598

Summary: [MacOS & iOS] animations/leak-document-with-css-animation.html is a flaky failure
Product: WebKit Reporter: Amir Mark Jr <amir_mark>
Component: Tools / TestsAssignee: ayumi_kojima
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ayumi_kojima, cdumez, dino, fujii.hironori, graouts, jenner, koivisto, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update TestExpectations
none
Patch none

Amir Mark Jr
Reported 2021-06-03 14:25:26 PDT
animations/leak-document-with-css-animation.html Is a flaky failure on Big Sur E Wk1 Release and Catalina E WK2 Release History: https://results.webkit.org/?suite=layout-tests&test=animations%2Fleak-document-with-css-animation.html Text Diff: --- /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/animations/leak-document-with-css-animation-expected.txt +++ /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/animations/leak-document-with-css-animation-actual.txt @@ -5,7 +5,7 @@ The iframe has finished loading. The iframe has been destroyed. -PASS internals.numberOfLiveDocuments() is numberOfLiveDocumentsAfterIframeLoaded - 1 +FAIL internals.numberOfLiveDocuments() should be 16. Was 15. PASS successfullyParsed is true
Attachments
Update TestExpectations (1.60 KB, text/plain)
2021-07-12 16:19 PDT, ayumi_kojima 		no flags
Details
Patch (1.49 KB, patch)
2021-07-12 16:41 PDT, ayumi_kojima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-03 14:25:47 PDT
<rdar://problem/78836186>
Amir Mark Jr
Comment 2 2021-06-03 16:22:15 PDT
Updated test expectations: https://trac.webkit.org/changeset/278427/webkit
Alexey Proskuryakov
Comment 3 2021-06-06 13:19:24 PDT
This seems like a bad test that should be testing for "less than", not equality? Pre-existing documents can happen to get collected too. We really need a better way to check for GC than looking at document counts.
ayumi_kojima
Comment 4 2021-07-12 16:13:34 PDT
The failure is also seen on iOS 14 E Simulator Release. Couldn't reproduce the failure at tip of tree and a recent revision that shows a failure (r279826). Tried: rwt animations/leak-document-with-css-animation.html --iterations 500 -f --ios-simulator rwt animations/leak-document-with-css-animation.html --iterations 50 -f --child-process 20 --ios-simulator rwt animations/leak-document-with-css-animation.html --iterations 50 -f --ios-simulator
ayumi_kojima
Comment 5 2021-07-12 16:13:53 PDT
The flaky failure is also seen on iOS 14 E Simulator Release. Couldn't reproduce the failure at tip of tree and a recent revision that shows a failure (r279826). Tried: rwt animations/leak-document-with-css-animation.html --iterations 500 -f --ios-simulator rwt animations/leak-document-with-css-animation.html --iterations 50 -f --child-process 20 --ios-simulator rwt animations/leak-document-with-css-animation.html --iterations 50 -f --ios-simulator
ayumi_kojima
Comment 6 2021-07-12 16:19:54 PDT
Created attachment 433368 [details] Update TestExpectations
Robert Jenner
Comment 7 2021-07-12 16:31:35 PDT
Comment on attachment 433368 [details] Update TestExpectations Change where expectation is filed from platform/ios-simulator-wk2/TestExpectations. to just platform/ios-wk2/TestExpectations.
ayumi_kojima
Comment 8 2021-07-12 16:41:09 PDT
Created attachment 433371 [details] Patch
Robert Jenner
Comment 9 2021-07-12 16:49:23 PDT
Comment on attachment 433371 [details] Patch Clearing Flags on attachment: 433371 Committed r279857 (239611@main): <https://commits.webkit.org/239611@main>
Fujii Hironori
Comment 10 2022-07-12 05:03:05 PDT
Fixed by 252375@main.
Note You need to log in before you can comment on or make changes to this bug.