Bug 226596

Summary: Stop storing Ref<IPC::Connection> in RTCDataChannelRemoteManagerProxy::m_webProcessConnections
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-06-03 13:38:41 PDT
Stop storing Ref<IPC::Connection> in RTCDataChannelRemoteManagerProxy::m_webProcessConnections. Keeping the IPC::Connection alive always carries the chance of leaking if we fail to properly clear the HashMap. We can simply store an IPC::Connection::UniqueID and use that ID to send the IPC on the background thread.
Attachments
Patch (6.97 KB, patch)
2021-06-03 13:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-03 13:39:46 PDT
Created attachment 430496 [details] Patch
EWS
Comment 2 2021-06-03 14:34:14 PDT
Committed r278420 (238444@main): <https://commits.webkit.org/238444@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430496 [details].
Radar WebKit Bug Importer
Comment 3 2021-06-03 14:35:21 PDT
<rdar://problem/78836798>
Note You need to log in before you can comment on or make changes to this bug.