Bug 226588

Summary: [macOS] Image extraction preview panel should automatically close when the web view is unparented
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, hi, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Handle WP termination as well
none
Patch ews-feeder: commit-queue-

Wenson Hsieh
Reported 2021-06-03 10:28:30 PDT
rdar://77062762
Attachments
Patch (10.59 KB, patch)
2021-06-03 10:51 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Handle WP termination as well (10.90 KB, patch)
2021-06-03 11:12 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (10.93 KB, patch)
2021-06-03 11:16 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-06-03 10:51:01 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-06-03 11:12:14 PDT
Created attachment 430486 [details] Handle WP termination as well
Tim Horton
Comment 3 2021-06-03 11:14:09 PDT
Comment on attachment 430486 [details] Handle WP termination as well View in context: https://bugs.webkit.org/attachment.cgi?id=430486&action=review > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2408 > + m_page->closeSharedPreviewPanelIfNecessary(); maybe stick this right next to dismissContentRelativeChildWindowsWithAnimation above?
Wenson Hsieh
Comment 4 2021-06-03 11:15:02 PDT
Thanks for the review! (In reply to Tim Horton from comment #3) > Comment on attachment 430486 [details] > Handle WP termination as well > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430486&action=review > > > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2408 > > + m_page->closeSharedPreviewPanelIfNecessary(); > > maybe stick this right next to > dismissContentRelativeChildWindowsWithAnimation above? Makes sense — moved to right after the `dismissContentRelativeChildWindowsWithAnimation(false);`.
Wenson Hsieh
Comment 5 2021-06-03 11:16:31 PDT
Created attachment 430488 [details] Patch
EWS
Comment 6 2021-06-03 12:40:06 PDT
Committed r278414 (238439@main): <https://commits.webkit.org/238439@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430488 [details].
Note You need to log in before you can comment on or make changes to this bug.