Bug 226587

Summary: Fix #include path for some Glib header files
Product: WebKit Reporter: Mohammad Imran <mohdimran.webkit>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: bugs-noreply, dvpdiner2, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch file to update correct path for glib header files on WebKitGTK port
mcatanzaro: review-
WebKit error build log none

Mohammad Imran
Reported 2021-06-03 08:31:46 PDT
Created attachment 430473 [details] Patch file to update correct path for glib header files on WebKitGTK port The following *.cpp files were using incorrect include path for their respective glib header files. This was causing missing header files errors while building WebkitGTK port on Ubuntu 20.04. 1. Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp - 2. Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp 3. Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp This patch include paths to use their correct <> path.
Attachments
Patch file to update correct path for glib header files on WebKitGTK port (1.70 KB, patch)
2021-06-03 08:31 PDT, Mohammad Imran 		mcatanzaro: review-
DetailsFormatted DiffDiff
WebKit error build log (461.02 KB, text/plain)
2021-06-03 14:53 PDT, Darryl Pogue 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2021-06-03 08:48:07 PDT
Comment on attachment 430473 [details] Patch file to update correct path for glib header files on WebKitGTK port I'm afraid you're going to have to investigate the CMake build system to see what include paths are missing and where. We don't use multi-level includes like this.
Darryl Pogue
Comment 2 2021-06-03 14:53:39 PDT
Created attachment 430501 [details] WebKit error build log I'm also seeing this error with the header includes. I did a fresh clone of WebKit this morning and ran the following: Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --makeargs="-j2" Build failure error log attached.
Darryl Pogue
Comment 3 2021-10-17 17:16:53 PDT
This was fixed in https://commits.webkit.org/242819@main
Michael Catanzaro
Comment 4 2021-10-17 17:27:16 PDT
Thanks for noticing.
Note You need to log in before you can comment on or make changes to this bug.