Bug 226578

Summary: Reintroduce logging useful for debugging in AudioSampleDataSource
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2021-06-03 06:25:44 PDT 
Reintroduce logging useful for debugging in AudioSampleDataSource
Comment 1 youenn fablet 2021-06-03 06:37:22 PDT 
Created attachment 430465 [details]
Patch
Comment 2 youenn fablet 2021-06-03 11:08:33 PDT 
Comment on attachment 430465 [details]
Patch

I tried reducing the logging to the minimal case.
I guess we could try further optimisations so that callOnMainThread would not always trigger an allocation but I think this is fine without it.
Comment 3 EWS 2021-06-04 05:05:07 PDT 
Committed r278453 (238473@main): <https://commits.webkit.org/238473@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430465 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-04 05:06:16 PDT 
<rdar://problem/78864972>