Bug 226578

Summary: Reintroduce logging useful for debugging in AudioSampleDataSource
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2021-06-03 06:25:44 PDT
Reintroduce logging useful for debugging in AudioSampleDataSource
Attachments
Patch (4.20 KB, patch)
2021-06-03 06:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-06-03 06:37:22 PDT
Created attachment 430465 [details] Patch
youenn fablet
Comment 2 2021-06-03 11:08:33 PDT
Comment on attachment 430465 [details] Patch I tried reducing the logging to the minimal case. I guess we could try further optimisations so that callOnMainThread would not always trigger an allocation but I think this is fine without it.
EWS
Comment 3 2021-06-04 05:05:07 PDT
Committed r278453 (238473@main): <https://commits.webkit.org/238473@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430465 [details].
Radar WebKit Bug Importer
Comment 4 2021-06-04 05:06:16 PDT
<rdar://problem/78864972>
Note You need to log in before you can comment on or make changes to this bug.