Bug 226555

Summary: [Cocoa] Clean up notification_center message filters
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: kkinnunen, pvollan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223072    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2021-06-02 14:59:14 PDT
We initially had two groups of mach-message-send filter rules for 'com.apple.system.notification_center' so we could collect telemetry on a group of messages. Now that we have removed all the messages we do not need, there is no reason to maintain two separate sets. This patch just combines the two sets into a single list so we can easily conditionalize it for different OS releases if needed. <rdar://problem/77164076>
Attachments
Patch (2.36 KB, patch)
2021-06-02 15:00 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2021-06-02 15:00:45 PDT
Created attachment 430411 [details] Patch
Per Arne Vollan
Comment 2 2021-06-02 15:01:54 PDT
Comment on attachment 430411 [details] Patch R=me.
EWS
Comment 3 2021-06-02 16:33:27 PDT
Committed r278383 (238410@main): <https://commits.webkit.org/238410@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430411 [details].
Note You need to log in before you can comment on or make changes to this bug.