Bug 226555 - [Cocoa] Clean up notification_center message filters
Summary: [Cocoa] Clean up notification_center message filters
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on: 223072
  Show dependency treegraph
Reported: 2021-06-02 14:59 PDT by Brent Fulgham
Modified: 2021-06-02 16:33 PDT (History)
2 users (show)

See Also:

Patch (2.36 KB, patch)
2021-06-02 15:00 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-06-02 14:59:14 PDT
We initially had two groups of mach-message-send filter rules for 'com.apple.system.notification_center' so we could collect telemetry on a group of messages. Now that we have removed all the messages we do not need, there is no reason to maintain two separate sets.

This patch just combines the two sets into a single list so we can easily conditionalize it for different OS releases if needed.

Comment 1 Brent Fulgham 2021-06-02 15:00:45 PDT
Created attachment 430411 [details]
Comment 2 Per Arne Vollan 2021-06-02 15:01:54 PDT
Comment on attachment 430411 [details]

Comment 3 EWS 2021-06-02 16:33:27 PDT
Committed r278383 (238410@main): <https://commits.webkit.org/238410@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430411 [details].