Bug 226508

Summary:

Fix unsafe access to m_upload in XMLHttpRequest::virtualHasPendingActivity()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2021-06-01 12:51:57 PDT

Fix unsafe access to m_upload in XMLHttpRequest::virtualHasPendingActivity() as virtualHasPendingActivity() may get called off the main thread and m_upload gets initialized lazily on the main thread.

Comment 1 Chris Dumez 2021-06-01 12:54:35 PDT

Created attachment 430282 [details]
Patch

Comment 2 Geoffrey Garen 2021-06-01 13:19:58 PDT

Comment on attachment 430282 [details]
Patch

r=me

Comment 3 EWS 2021-06-01 15:03:42 PDT

Committed r278329 (238362@main): <https://commits.webkit.org/238362@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430282 [details].

Comment 4 Radar WebKit Bug Importer 2021-06-01 15:04:18 PDT

<rdar://problem/78734398>