Bug 226507

Summary: [macOS] Data detector highlights should appear when hovering inside image overlays
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, esprehn+autocc, ews-watchlist, hi, kangil.han, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2021-06-01 12:50:39 PDT
.
Attachments
Patch (17.80 KB, patch)
2021-06-01 13:30 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (17.79 KB, patch)
2021-06-01 14:02 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-06-01 13:30:30 PDT
Created attachment 430287 [details] Patch
Tim Horton
Comment 2 2021-06-01 13:59:05 PDT
Comment on attachment 430287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430287&action=review > Source/WebCore/ChangeLog:10 > + allow the ImageOverlayController install its page overlay when the element under the mouse is inside an image "allow the ImageOverlayController install" grammar-o
Wenson Hsieh
Comment 3 2021-06-01 14:00:22 PDT
Comment on attachment 430287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430287&action=review Thanks for the review! >> Source/WebCore/ChangeLog:10 >> + allow the ImageOverlayController install its page overlay when the element under the mouse is inside an image > > "allow the ImageOverlayController install" grammar-o (Whoops.)
Wenson Hsieh
Comment 4 2021-06-01 14:02:46 PDT
Created attachment 430289 [details] Patch
EWS
Comment 5 2021-06-01 15:37:04 PDT
Committed r278331 (238364@main): <https://commits.webkit.org/238364@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430289 [details].
Radar WebKit Bug Importer
Comment 6 2021-06-01 15:38:18 PDT
<rdar://problem/78735990>
Note You need to log in before you can comment on or make changes to this bug.