Bug 226498

Summary: [EME][Thunder] Build broken since r278244
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, calvaris, cgarcia, darin, ews-watchlist, gustavo, menard, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2021-06-01 07:53:14 PDT
../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:678:12: error: cannot cast from type 'const WeakPtr<WebCore::CDMInstanceProxy>' to pointer type 'WebCore::CDMInstanceThunder *' return static_cast<CDMInstanceThunder*>(cdmInstanceProxy()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
Attachments
Patch (1.47 KB, patch)
2021-06-01 07:55 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-06-01 07:55:41 PDT
Created attachment 430262 [details] Patch
EWS
Comment 2 2021-06-01 11:50:23 PDT
Committed r278316 (238352@main): <https://commits.webkit.org/238352@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430262 [details].
Radar WebKit Bug Importer
Comment 3 2021-06-01 11:51:21 PDT
<rdar://problem/78725269>
Darin Adler
Comment 4 2021-06-01 13:23:07 PDT
Comment on attachment 430262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430262&action=review > Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:679 > - return static_cast<CDMInstanceThunder*>(cdmInstanceProxy()); > + auto proxy = cdmInstanceProxy(); > + return static_cast<CDMInstanceThunder*>(proxy.get()); Adding the ".get()" was good. But adding the local variable was unnecessary.
Note You need to log in before you can comment on or make changes to this bug.