| Summary: | [EME][Thunder] Build broken since r278244 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, calvaris, cgarcia, darin, ews-watchlist, gustavo, menard, vjaquez, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 430262 [details]
Patch
Committed r278316 (238352@main): <https://commits.webkit.org/238352@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430262 [details]. Comment on attachment 430262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430262&action=review > Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:679 > - return static_cast<CDMInstanceThunder*>(cdmInstanceProxy()); > + auto proxy = cdmInstanceProxy(); > + return static_cast<CDMInstanceThunder*>(proxy.get()); Adding the ".get()" was good. But adding the local variable was unnecessary. |
../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:678:12: error: cannot cast from type 'const WeakPtr<WebCore::CDMInstanceProxy>' to pointer type 'WebCore::CDMInstanceThunder *' return static_cast<CDMInstanceThunder*>(cdmInstanceProxy()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.